x86/svm: Don't shadow variables in svm_vmexit_handler()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 25 Nov 2019 13:29:20 +0000 (13:29 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 5 Dec 2019 13:19:28 +0000 (13:19 +0000)
commit115c05a5f9b78ee596895065ee4a28c106096771
tree18a5a43ee335b2b3d128b95ada6b42ddeeec5e4c
parentda650d3810909d6d17f9aa7a3eecee2088adb6cf
x86/svm: Don't shadow variables in svm_vmexit_handler()

The local variable eventinj is set to the value of vmcb->exitintinfo which is
confusing considering that it isn't vmcb->eventinj.  The variable isn't
necessary to begin with, so drop it to avoid confusion.

A local rc variable is shadowed in the CPUID, #DB and #BP handlers.

There is a mix of spelling of inst_len and insn_len, all of which are
logically the same value.  Consolidate on insn_len which also matches the name
of the emulation functions for obtaining instruction lengths, and avoid
shadowing it in the CPUID and TASK_SWITCH handlers.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/hvm/svm/svm.c